Fix use-after-free in exception replay

[bwoebi]

Depending on where the exception originates, a span may have been part of it and be freed during serialization. Immediately send to avoid dangling pointers.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.21%. Comparing base (e2b0a15) to head (495a98d).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2947      +/-   ##
============================================
- Coverage     73.62%   72.21%   -1.42%     
  Complexity     2529     2529              
============================================
  Files           109      136      +27     
  Lines         10410    14452    +4042     
  Branches          0      991     +991     
============================================
+ Hits           7664    10436    +2772     
- Misses         2746     3472     +726     
- Partials          0      544     +544     

Flag	Coverage Δ
appsec-extension	68.57% <ø> (?)
tracer-php	73.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b0a15...495a98d. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-13 13:46:56

Comparing candidate commit 495a98d in PR branch bob/exception-debugger-uaf with baseline commit e2b0a15 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-8.826µs; -4.574µs] or [-4.382%; -2.271%]