[loader] Fix compatilibity with PHP 5 #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous build could be loaded with php:5.6 docker image and I believe on centos 7 also. But on ubuntu:22.04, there were issues like "undefined symbol: __zend_malloc". This PR fixes this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2939 +/- ##
============================================
+ Coverage 82.10% 82.16% +0.05%
Complexity 2527 2527
============================================
Files 108 108
Lines 10360 10360
============================================
+ Hits 8506 8512 +6
+ Misses 1854 1848 -6
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous build could be loaded with php:5.6 docker image and I believe on centos 7 also. But on Ubuntu 22.04, there were issues like
undefined symbol: __zend_malloc.This PR fixes this.
https://datadoghq.atlassian.net/browse/INPLAT-180
Reviewer checklist