Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove version from OpenAI snapshots child spans #2929

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Nov 6, 2024

Description

Follow-up to #2896. The OpenAI tests started failing because the PSR child spans doesn't have the version in the metadata (sample failure).

This PR removes version from the expected metadata in every child spans from the OpenAI tests.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

If you need to update snapshots, please refer to CONTRIBUTING.md

42 occurrences of :

- "span.kind": "client"
- "version": "1.0"
+ "span.kind": "client"

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (a1ec6f8) to head (043f459).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2929      +/-   ##
============================================
+ Coverage     72.39%   82.10%   +9.70%     
  Complexity     2527     2527              
============================================
  Files           135      108      -27     
  Lines         14399    10359    -4040     
  Branches        989        0     -989     
============================================
- Hits          10424     8505    -1919     
+ Misses         3432     1854    -1578     
+ Partials        543        0     -543     
Flag Coverage Δ
appsec-extension ?
tracer-php 82.10% <ø> (+8.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ec6f8...043f459. Read the comment docs.

@PROFeNoM PROFeNoM marked this pull request as ready for review November 6, 2024 12:38
@PROFeNoM PROFeNoM requested a review from a team as a code owner November 6, 2024 12:38
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up.

@PROFeNoM PROFeNoM merged commit 0e77db0 into master Nov 6, 2024
663 of 688 checks passed
@PROFeNoM PROFeNoM deleted the alex/tests/remove-version-openai-child branch November 6, 2024 12:48
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants