Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hooks on trampoline fake closures #2925

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 5, 2024

It may not be perfect, but we cannot trivially check for zend_closure_call_magic being the internal method due to that one being static. I assume it to be good enough unless proven otherwise.

@bwoebi bwoebi requested a review from a team as a code owner November 5, 2024 15:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.87%. Comparing base (1b40137) to head (83e15be).
Report is 17 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1b40137) and HEAD (83e15be). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1b40137) HEAD (83e15be)
tracer-php 11 10
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2925       +/-   ##
=============================================
- Coverage     72.39%   51.87%   -20.53%     
  Complexity     2526     2526               
=============================================
  Files           135      135               
  Lines         14400    14400               
  Branches        989      989               
=============================================
- Hits          10425     7470     -2955     
- Misses         3433     6388     +2955     
  Partials        542      542               
Flag Coverage Δ
appsec-extension 68.36% <ø> (ø)
tracer-php 45.44% <ø> (-28.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b40137...83e15be. Read the comment docs.

It may not be perfect, but we cannot trivially check for zend_closure_call_magic being the internal method due to that one being static.
I assume it to be good enough unless proven otherwise.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/trampoline-hook branch from 4aa92a1 to 83e15be Compare November 6, 2024 16:28
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-06 16:56:23

Comparing candidate commit 83e15be in PR branch bob/trampoline-hook with baseline commit 1b40137 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchInject64Bit

  • 🟥 execution_time [+415.614ns; +608.386ns] or [+5.539%; +8.109%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-13.082µs; -8.321µs] or [-6.852%; -4.358%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+4.547µs; +11.758µs] or [+2.569%; +6.642%]

@bwoebi bwoebi merged commit 1adda6c into master Nov 7, 2024
719 of 744 checks passed
@bwoebi bwoebi deleted the bob/trampoline-hook branch November 7, 2024 12:28
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants