Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Tag Keys for DD_TRACE_HEADER_TAGS #2922

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Nov 5, 2024

Description

Adding Support for allowing customers to pass : separated values in the list of header tags which they would like to use the key instead of the current header name only.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (9d93b40) to head (2f104b2).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2922   +/-   ##
=========================================
  Coverage     78.24%   78.24%           
  Complexity     2526     2526           
=========================================
  Files           135      135           
  Lines         14400    14400           
  Branches        989      989           
=========================================
  Hits          11267    11267           
  Misses         2591     2591           
  Partials        542      542           
Flag Coverage Δ
appsec-extension 68.36% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d93b40...2f104b2. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-06 19:22:18

Comparing candidate commit 2f104b2 in PR branch maximo/consistent-header-tags with baseline commit 9d93b40 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-11.004µs; -7.496µs] or [-5.675%; -3.866%]

@bwoebi
Copy link
Collaborator

bwoebi commented Nov 5, 2024

Implementation looks good so far, but peer service tests seems to want that you ignore these cases without the colon. (and tea tests do need some updates too).

@bwoebi
Copy link
Collaborator

bwoebi commented Nov 6, 2024

Just styling notes, looks good now :-)

@link04 link04 marked this pull request as ready for review November 6, 2024 17:27
@link04 link04 requested a review from a team as a code owner November 6, 2024 17:27
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Maximo :-)

@link04 link04 merged commit db89e26 into master Nov 6, 2024
547 of 577 checks passed
@link04 link04 deleted the maximo/consistent-header-tags branch November 6, 2024 19:38
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants