-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Tag Keys for DD_TRACE_HEADER_TAGS #2922
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2922 +/- ##
=========================================
Coverage 78.24% 78.24%
Complexity 2526 2526
=========================================
Files 135 135
Lines 14400 14400
Branches 989 989
=========================================
Hits 11267 11267
Misses 2591 2591
Partials 542 542
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2024-11-06 19:22:18 Comparing candidate commit 2f104b2 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
Implementation looks good so far, but peer service tests seems to want that you ignore these cases without the colon. (and tea tests do need some updates too). |
Just styling notes, looks good now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Maximo :-)
Description
Adding Support for allowing customers to pass
:
separated values in the list of header tags which they would like to use the key instead of the current header name only.Reviewer checklist