Fixing DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP Empty Value Behavior

[link04]

Description

Updating what should happen if the value for DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP is set to an empty string since as of today it was redacting everything in system tests.

https://datadoghq.atlassian.net/browse/APMAPI-499

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.35%. Comparing base (1b40137) to head (d77bcda).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/DDTrace/Util/Normalizer.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2909      +/-   ##
============================================
- Coverage     72.39%   72.35%   -0.05%     
- Complexity     2526     2527       +1     
============================================
  Files           135      135              
  Lines         14400    14399       -1     
  Branches        989      989              
============================================
- Hits          10425    10418       -7     
- Misses         3433     3439       +6     
  Partials        542      542              

Flag	Coverage Δ
appsec-extension	68.36% <ø> (ø)
tracer-php	73.90% <0.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/DDTrace/Util/Normalizer.php	68.38% <0.00%> (+0.49%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b40137...d77bcda. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-05 19:48:14

Comparing candidate commit d77bcda in PR branch maximo/consistent-query-string-regexp-config with baseline commit 1b40137 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceFlushBench/benchFlushTrace

• 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

[bwoebi]

I think empty string handling is missing in Normalizer.php. I.e. it should also always match there with an empty string.

[bwoebi]

In fact I'm just seeing 5f1f193, is there a specific reason you reverted that? (it should just return [$postKey => $postVal]; unconditionally, when the string is empty, too.)

[bwoebi]

Looks right. Merging :-)