Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send git tags via remote config #2890

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Send git tags via remote config #2890

merged 3 commits into from
Oct 14, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 11, 2024

See DataDog/system-tests#3212 - we need to submit these.

@bwoebi bwoebi requested review from a team as code owners October 11, 2024 12:29
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (b23438e) to head (a3e85fc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2890      +/-   ##
============================================
+ Coverage     78.23%   78.24%   +0.01%     
  Complexity     2526     2526              
============================================
  Files           173      173              
  Lines         18742    18742              
  Branches        981      981              
============================================
+ Hits          14662    14664       +2     
+ Misses         3540     3538       -2     
  Partials        540      540              
Flag Coverage Δ
appsec-extension 68.49% <ø> (ø)
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23438e...a3e85fc. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-11 15:50:30

Comparing candidate commit a3e85fc in PR branch bob/rc-tags with baseline commit b23438e in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟩 execution_time [-230.329µs; -82.911µs] or [-7.630%; -2.746%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-12.282µs; -10.648µs] or [-6.393%; -5.543%]

@bwoebi bwoebi requested a review from a team as a code owner October 11, 2024 13:53
@bwoebi bwoebi force-pushed the bob/rc-tags branch 3 times, most recently from 2a8fc0e to bce0358 Compare October 11, 2024 14:04
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 65d305a into master Oct 14, 2024
126 of 409 checks passed
@bwoebi bwoebi deleted the bob/rc-tags branch October 14, 2024 02:05
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 14, 2024
@bwoebi bwoebi modified the milestones: 1.5.0, 1.4.1 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants