Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak with sidecar trace sender #2875

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 4, 2024

And set LSAN_OPTIONS=fast_unwind_on_malloc=0 for more complete traces.

@bwoebi bwoebi requested a review from a team as a code owner October 4, 2024 14:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (bb96a53) to head (b9fa0f0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2875   +/-   ##
=========================================
  Coverage     80.91%   80.91%           
  Complexity     2526     2526           
=========================================
  Files           146      146           
  Lines         14711    14711           
=========================================
  Hits          11903    11903           
  Misses         2808     2808           
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb96a53...b9fa0f0. Read the comment docs.

@bwoebi bwoebi force-pushed the bob/ffi_try_sync_flush branch from cbe032b to 19d324a Compare October 4, 2024 14:41
@pr-commenter
Copy link

pr-commenter bot commented Oct 4, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-10-04 17:06:05

Comparing candidate commit b9fa0f0 in PR branch bob/ffi_try_sync_flush with baseline commit bb96a53 in branch master.

Found 2 performance improvements and 3 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-10.452µs; -7.288µs] or [-6.020%; -4.198%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-7.385µs; -4.895µs] or [-4.371%; -2.897%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+5.445µs; +12.180µs] or [+3.032%; +6.782%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+11.509µs; +15.709µs] or [+6.421%; +8.764%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+168.595ns; +627.805ns] or [+2.461%; +9.163%]

@bwoebi bwoebi force-pushed the bob/ffi_try_sync_flush branch from 19d324a to 480078a Compare October 4, 2024 15:16
@bwoebi bwoebi force-pushed the bob/ffi_try_sync_flush branch 2 times, most recently from 0d94b95 to b9fa0f0 Compare October 4, 2024 16:38
@bwoebi bwoebi force-pushed the bob/ffi_try_sync_flush branch from b9fa0f0 to a2ef23e Compare October 14, 2024 02:22
And set LSAN_OPTIONS=fast_unwind_on_malloc=0 for more complete traces
@bwoebi bwoebi force-pushed the bob/ffi_try_sync_flush branch from a2ef23e to 9387bec Compare October 14, 2024 02:23
@bwoebi bwoebi merged commit 6751be9 into master Oct 14, 2024
9 of 14 checks passed
@bwoebi bwoebi deleted the bob/ffi_try_sync_flush branch October 14, 2024 02:23
@github-actions github-actions bot modified the milestone: 1.5.0 Oct 14, 2024
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing area:asm labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:asm profiling Relates to the Continuous Profiler tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants