-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CLI by default #2871
Enable CLI by default #2871
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2871 +/- ##
=========================================
Coverage 80.91% 80.91%
Complexity 2526 2526
=========================================
Files 146 146
Lines 14706 14706
=========================================
Hits 11900 11900
Misses 2806 2806
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
67580a7
to
4c54627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should set the default value to auto
(or create a new ini config), which would be paired with an allow/deny list.
For example, I don’t think we should enable it by default for composer
🤔
@iamluc that's reasonable and probably the only exception I can think of. "if name == composer or composer.phar"... |
845da6c
to
c0e925d
Compare
And enable autoflushing by default in CLI environments. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
c0e925d
to
f60e3c4
Compare
And enable autoflushing by default in CLI environments.
Especially with SSI, this enables us to actually instrument CLI scripts transparently as well.