Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CLI by default #2871

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Enable CLI by default #2871

merged 3 commits into from
Oct 3, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 2, 2024

And enable autoflushing by default in CLI environments.

Especially with SSI, this enables us to actually instrument CLI scripts transparently as well.

@bwoebi bwoebi requested review from a team as code owners October 2, 2024 18:31
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (ee973a5) to head (22a6b6d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2871   +/-   ##
=========================================
  Coverage     80.91%   80.91%           
  Complexity     2526     2526           
=========================================
  Files           146      146           
  Lines         14706    14706           
=========================================
  Hits          11900    11900           
  Misses         2806     2806           
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee973a5...22a6b6d. Read the comment docs.

Copy link
Contributor

@iamluc iamluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should set the default value to auto (or create a new ini config), which would be paired with an allow/deny list.

For example, I don’t think we should enable it by default for composer 🤔

@bwoebi
Copy link
Collaborator Author

bwoebi commented Oct 3, 2024

@iamluc that's reasonable and probably the only exception I can think of. "if name == composer or composer.phar"...

@bwoebi bwoebi force-pushed the bob/cli-default branch 2 times, most recently from 845da6c to c0e925d Compare October 3, 2024 18:04
bwoebi added 2 commits October 3, 2024 22:07
And enable autoflushing by default in CLI environments.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit 77f1a7f into master Oct 3, 2024
424 of 494 checks passed
@bwoebi bwoebi deleted the bob/cli-default branch October 3, 2024 21:31
@github-actions github-actions bot added this to the 1.4.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants