Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prefix system tests env vars #2868

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Oct 1, 2024

Description

Prefix system tests env vars to not conflict with local dev env vars.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@wconti27 wconti27 requested a review from a team as a code owner October 1, 2024 18:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (b8fde57) to head (925edd6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2868      +/-   ##
============================================
- Coverage     80.97%   78.41%   -2.57%     
  Complexity     2526     2526              
============================================
  Files           146      173      +27     
  Lines         14683    18713    +4030     
  Branches          0      976     +976     
============================================
+ Hits          11889    14673    +2784     
- Misses         2794     3503     +709     
- Partials          0      537     +537     
Flag Coverage Δ
appsec-extension 69.08% <ø> (?)
tracer-extension 78.26% <ø> (ø)
tracer-php 82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8fde57...925edd6. Read the comment docs.

@wconti27 wconti27 merged commit 9d44320 into master Oct 2, 2024
691 of 697 checks passed
@wconti27 wconti27 deleted the conti/prefix-system-tests-env-vars branch October 2, 2024 15:04
@github-actions github-actions bot added this to the 1.4.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants