Fix OpenTracing test flakiness #2867
Conversation
| $span->setTag('http.method', $_SERVER['REQUEST_METHOD']); | ||
| $span->finish(); | ||
| } finally { | ||
| \dd_trace_internal_fn("finalize_telemetry"); |
There was a problem hiding this comment.
Calling finalize_telemetry manually causes the metrics (like spans_created) to be sent twice.
Once with service_name as service name, the other with index.php
There was a problem hiding this comment.
I think back in the old times finalize_telemetry was final :-) (But I think that matters no longer.)
|
|
||
| $metrics = []; | ||
| foreach ($metricRequests[0]['payload']['series'] as $serie) { | ||
| $metrics[$serie['metric']][] = $serie; |
There was a problem hiding this comment.
We also receive other metrics (like logs_created), that's why we group them
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2867 +/- ##
============================================
+ Coverage 78.41% 80.97% +2.56%
Complexity 2526 2526
============================================
Files 173 146 -27
Lines 18713 14683 -4030
Branches 976 0 -976
============================================
- Hits 14673 11889 -2784
+ Misses 3503 2794 -709
+ Partials 537 0 -537
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
Reviewer checklist