Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate more memory for link_extension step #2866

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Oct 1, 2024

Root cause of #2865 - using a large instead of a medium circleci instance.

And changing the build step so that it will properly fail now if any command fails.

bwoebi added 2 commits October 1, 2024 03:08
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from a team as a code owner October 1, 2024 01:22
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (f4b4015) to head (61f99d4).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2866      +/-   ##
============================================
- Coverage     78.41%   78.40%   -0.02%     
  Complexity     2526     2526              
============================================
  Files           173      173              
  Lines         18713    18713              
  Branches        976      976              
============================================
- Hits          14673    14671       -2     
- Misses         3503     3505       +2     
  Partials        537      537              
Flag Coverage Δ
appsec-extension 69.08% <ø> (ø)
tracer-extension 78.26% <ø> (ø)
tracer-php 82.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b4015...61f99d4. Read the comment docs.

Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising that this got through somehow. I think maybe we should do a little more to ensure the artifacts are installable, but I object to nothing in this PR, so approved.

@bwoebi
Copy link
Collaborator Author

bwoebi commented Oct 1, 2024

@morrisonlevi It looks like it just affected a single version on a single target. But yes :-X

@bwoebi bwoebi merged commit 0678d4f into master Oct 1, 2024
694 of 697 checks passed
@bwoebi bwoebi deleted the bob/link_extension_ram branch October 1, 2024 11:27
@github-actions github-actions bot added this to the 1.4.0 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants