Loader: disable the tracer in case of a potential incompatibility (extension/jit)

[iamluc]

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (3746a2f) to head (98fc95f).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2853      +/-   ##
============================================
+ Coverage     78.39%   78.41%   +0.01%     
  Complexity     2526     2526              
============================================
  Files           173      173              
  Lines         18710    18713       +3     
  Branches        976      976              
============================================
+ Hits          14667    14673       +6     
+ Misses         3506     3503       -3     
  Partials        537      537              

Flag	Coverage Δ
appsec-extension	69.08% <ø> (ø)
tracer-extension	78.26% <100.00%> (+0.08%)	⬆️
tracer-php	82.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
zend_abstract_interface/hook/hook.c	54.98% <100.00%> (+0.55%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3746a2f...98fc95f. Read the comment docs.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2024-09-19 16:25:56

Comparing candidate commit 98fc95f in PR branch luc/loader-incompat-extensions with baseline commit 3746a2f in branch master.

Found 5 performance improvements and 4 performance regressions! Performance is the same for 169 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline

• 🟥 execution_time [+62.126µs; +221.334µs] or [+2.133%; +7.600%]

scenario:LaravelBench/benchLaravelOverhead

• 🟥 execution_time [+68.823µs; +210.117µs] or [+2.180%; +6.656%]

scenario:PDOBench/benchPDOBaseline

• 🟩 execution_time [-14.046µs; -11.164µs] or [-7.277%; -5.784%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟥 execution_time [+12.831µs; +14.077µs] or [+7.147%; +7.841%]

scenario:PDOBench/benchPDOOverhead

• 🟩 execution_time [-14.536µs; -13.125µs] or [-5.080%; -4.587%]

scenario:PDOBench/benchPDOOverhead-opcache

• 🟥 execution_time [+12.594µs; +14.664µs] or [+4.355%; +5.070%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟩 execution_time [-550.796ns; -235.604ns] or [-7.396%; -3.163%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

• 🟩 execution_time [-517.820ns; -164.580ns] or [-7.234%; -2.299%]

scenario:WordPressBench/benchWordPressOverhead

• 🟩 execution_time [-21.840ms; -21.611ms] or [-82.938%; -82.071%]

[bwoebi]

Looks good to me, thanks :-)