-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ini config datadog.crashtracking_enabled
#2850
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2850 +/- ##
============================================
- Coverage 78.39% 78.38% -0.02%
Complexity 2526 2526
============================================
Files 173 173
Lines 18710 18710
Branches 976 976
============================================
- Hits 14667 14665 -2
- Misses 3506 3508 +2
Partials 537 537
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
847d7dd
to
8255aae
Compare
BenchmarksBenchmark execution time: 2024-09-13 16:21:27 Comparing candidate commit 0d088b1 in PR branch Found 10 performance improvements and 3 performance regressions! Performance is the same for 165 metrics, 0 unstable metrics. scenario:BM_TeaSapiSpindown
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache
scenario:WordPressBench/benchWordPressOverhead
|
…clusive with DD_CRASHTRACKING_ENABLED
0d088b1
to
6242e01
Compare
Benchmarks [ tracer ]Benchmark execution time: 2024-09-18 16:23:05 Comparing candidate commit 810ddce in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 175 metrics, 0 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:PDOBench/benchPDOBaseline-opcache
scenario:WordPressBench/benchWordPressOverhead
|
6242e01
to
810ddce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description
Corresponding env var
DD_CRASHTRACKING_ENABLED
is handled at least by dd-trace-dotnet and dd-trace-py, and is required by a system-test.Additionally, I reduced the wait time in the request replayer.
Previously, the default was 5 seconds per iteration with a maximum of 100 iterations.
Now, it’s 0.5 seconds per iteration, with a maximum of 200 iterations (500 on Windows).
Reviewer checklist