Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests using Predis #2846

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Sep 11, 2024

Description

Both scenarios DeferredLoading and Predis were running composer install in the same directory.
It seems it could break the installation

i.e. https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/17446/workflows/0a933327-d943-4704-b7c9-4f9f560cb329/jobs/5142824

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (ebaa1ca) to head (8f066a7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2846   +/-   ##
=========================================
  Coverage     81.06%   81.06%           
  Complexity     2516     2516           
=========================================
  Files           146      146           
  Lines         14653    14653           
=========================================
  Hits          11879    11879           
  Misses         2774     2774           
Flag Coverage Δ
tracer-extension 78.18% <ø> (ø)
tracer-php 82.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaa1ca...8f066a7. Read the comment docs.

@iamluc iamluc force-pushed the luc/fix-composer-install-issue-predis branch from d98ba95 to c3b3514 Compare September 11, 2024 13:44
@iamluc iamluc force-pushed the luc/fix-composer-install-issue-predis branch from c3b3514 to 8f066a7 Compare September 12, 2024 08:06
@iamluc iamluc marked this pull request as ready for review September 12, 2024 09:30
@iamluc iamluc requested a review from a team as a code owner September 12, 2024 09:30
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my mistake, thanks for catching :-)

@iamluc iamluc merged commit ddf15fe into master Sep 12, 2024
634 of 639 checks passed
@iamluc iamluc deleted the luc/fix-composer-install-issue-predis branch September 12, 2024 10:00
@github-actions github-actions bot added this to the 1.4.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants