Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSI requirements.json file #2813

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Add SSI requirements.json file #2813

merged 4 commits into from
Oct 3, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Aug 26, 2024

Description

Draft, as the RFC might still change.

Implementation of the RFC

Tested manually on allow_tests.json/block_tests.json using the validator introduced in this PR.

This PR does not add a CI job to check the file as one will be added to the shared-pipeline

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (f87446c) to head (4eb8229).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2813      +/-   ##
============================================
- Coverage     80.91%   80.90%   -0.02%     
  Complexity     2526     2526              
============================================
  Files           146      146              
  Lines         14706    14706              
============================================
- Hits          11900    11898       -2     
- Misses         2806     2808       +2     
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 82.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87446c...4eb8229. Read the comment docs.

@iamluc iamluc force-pushed the luc/ssi-deny-list branch 3 times, most recently from a677360 to eed0bed Compare September 5, 2024 15:41
@iamluc iamluc marked this pull request as ready for review September 5, 2024 15:49
@iamluc iamluc requested a review from a team as a code owner September 5, 2024 15:49
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💪

loader/packaging/requirements.json Outdated Show resolved Hide resolved
@iamluc iamluc marked this pull request as draft September 9, 2024 15:01
@iamluc iamluc force-pushed the luc/ssi-deny-list branch 2 times, most recently from 6b04bd9 to 12736c1 Compare September 23, 2024 13:10
@iamluc iamluc marked this pull request as ready for review September 24, 2024 14:17
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@iamluc iamluc force-pushed the luc/ssi-deny-list branch from 50f10f7 to 4eb8229 Compare October 3, 2024 06:40
@iamluc iamluc merged commit 6eb87bc into master Oct 3, 2024
641 of 648 checks passed
@iamluc iamluc deleted the luc/ssi-deny-list branch October 3, 2024 08:10
@github-actions github-actions bot added this to the 1.4.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants