-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppSec] Automated user ID collection modes #2782
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2782 +/- ##
============================================
- Coverage 79.27% 79.17% -0.10%
Complexity 2452 2452
============================================
Files 169 169
Lines 18018 18052 +34
Branches 904 913 +9
============================================
+ Hits 14283 14293 +10
- Misses 3245 3264 +19
- Partials 490 495 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
c0df523
to
8cdfe4f
Compare
Description
This PR introduces the new user ID collection modes (
ident
,anon
,disabled
) which replace the old ones (safe
,extended
,disabled
). Some interesting facts:ident
mode is now the default one, meaning the user IDs are always collected.ident
oranon
mode.ident
oranon
mode.user_tracking.*
, in preparation for further work on authenticated user tracking.The system tests will fail due to the change on login events, however they have been updated here: https://github.com/DataDog/system-tests/compare/anilm3/php-user-events-v2?expand=1
The remote configuration changes have not been included in this PR given the ongoing work being done on the helper.
Related Jira: APPSEC-53749
Reviewer checklist