Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PDO spans to orphans removal #2743

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat: Add PDO spans to orphans removal #2743

merged 1 commit into from
Jul 10, 2024

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Jul 4, 2024

Description

AIDM-194

Fix #2732

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Jul 4, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2024

Benchmarks

Benchmark execution time: 2024-07-04 11:58:03

Comparing candidate commit c1942f4 in PR branch alex/gh/2732 with baseline commit aa31d0c in branch master.

Found 3 performance improvements and 4 performance regressions! Performance is the same for 171 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline

  • 🟥 execution_time [+79.203µs; +232.897µs] or [+3.381%; +9.940%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+13.721µs; +16.562µs] or [+7.904%; +9.541%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-17.966µs; -15.661µs] or [-9.424%; -8.215%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+15.602µs; +17.344µs] or [+5.662%; +6.294%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-15.240µs; -13.767µs] or [-5.114%; -4.620%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+15.660µs; +17.447µs] or [+5.229%; +5.826%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟩 execution_time [-15.614µs; -13.390µs] or [-4.694%; -4.025%]

@PROFeNoM PROFeNoM marked this pull request as ready for review July 9, 2024 12:36
@PROFeNoM PROFeNoM requested a review from a team as a code owner July 9, 2024 12:36
@PROFeNoM PROFeNoM merged commit 5b56e2f into master Jul 10, 2024
609 of 610 checks passed
@PROFeNoM PROFeNoM deleted the alex/gh/2732 branch July 10, 2024 12:32
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants