WAF telemetry #2735
Open
WAF telemetry #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2735 +/- ##
============================================
- Coverage 77.96% 77.77% -0.19%
Complexity 2216 2216
============================================
Files 227 227
Lines 26643 26737 +94
Branches 989 1017 +28
============================================
+ Hits 20771 20796 +25
- Misses 5346 5408 +62
- Partials 526 533 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-07-13 00:47:21 Comparing candidate commit a225a90 in PR branch Found 17 performance improvements and 0 performance regressions! Performance is the same for 161 metrics, 0 unstable metrics. scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
scenario:TraceSerializationBench/benchSerializeTrace
scenario:TraceSerializationBench/benchSerializeTrace-opcache
scenario:WordPressBench/benchWordPressOverhead
scenario:WordPressBench/benchWordPressOverhead-opcache
|
cataphract
force-pushed
the
glopes/waf-telemetry
branch
2 times, most recently
from
8464095
to
d91cd3f
Compare
iamluc
reviewed
Jun 28, 2024
ext/telemetry.c
Outdated
| @@ -240,3 +247,142 @@ void ddtrace_telemetry_send_trace_api_metrics(trace_api_metrics metrics) { | |||
|
|
|||
| ddog_sidecar_telemetry_buffer_flush(&ddtrace_sidecar, ddtrace_sidecar_instance_id, &dd_bgs_queued_id, buffer); | |||
| } | |||
|
|
|||
| ZEND_TLS HashTable metric_buffers; | |||
There was a problem hiding this comment.
Isn't it possible to use a buffer created by ddog_sidecar_telemetry_buffer_alloc and add the metrics directly into it instead of having 2 levels of buffers?
Then in dd_commit_metrics we could just flush it.
cataphract
force-pushed
the
glopes/waf-telemetry
branch
5 times, most recently
from
e777ab6
to
8239978
Compare
cataphract
force-pushed
the
glopes/waf-telemetry
branch
from
8239978
to
3cdc077
Compare
cataphract
force-pushed
the
glopes/waf-telemetry
branch
9 times, most recently
from
6b37ec2
to
ad72485
Compare
* Support aarch64 * Show the log of the sidecar * Update dependencies * Compile rust code in the tracer in debug mode * Fix build failing when gradle finds broken symlinks * Add PHP debug images (for troubleshooting) The images are now multiarch. See https://registry.hub.docker.com/r/datadog/dd-appsec-php-ci/tags
cataphract
force-pushed
the
glopes/waf-telemetry
branch
2 times, most recently
from
583b4db
to
1b22395
Compare
Introduces the interface metrics::TelemetrySubmitter and uses two implementations to submit metrics 1) RequestMetricsSubmitter: generated during a request, which are forwarded to the extension in that requests's rshutdown message and 2) MetricsImpl: generated outside a request, inside the service. These are forwarded to the extension in either client_init or rshutdown of any client of that service. This service is also used to submit the legacy meta and span metrics.
asio synchronous network APIs don't support timeouts. Switch to async APIs with stackless C++20 coroutine executor.
cataphract
force-pushed
the
glopes/waf-telemetry
branch
from
1b22395
to
a225a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See individual commits for descriptions of the changes.
Reviewer checklist