Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init OCI packaging for SSI #2723

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Init OCI packaging for SSI #2723

merged 4 commits into from
Jul 16, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Jun 19, 2024

Description

Based on #2684 Based on #2744

Include the pipeline in charge of creating and pushing an OCI package for SSI

This pipeline has no support for Alpine/musl yet, but we can implement this later.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc force-pushed the luc/ssi-oci-package branch 6 times, most recently from 34bff08 to a1d6fdc Compare June 20, 2024 10:42
@iamluc iamluc force-pushed the luc/ssi-library-loader branch from 3b584b1 to dc05737 Compare June 21, 2024 09:18
@iamluc iamluc force-pushed the luc/ssi-oci-package branch from a1d6fdc to de8587d Compare June 21, 2024 15:16
Base automatically changed from luc/ssi-library-loader to master June 26, 2024 11:28
@iamluc iamluc force-pushed the luc/ssi-oci-package branch from de8587d to 65d941c Compare June 26, 2024 11:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (93994c0) to head (4699915).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2723   +/-   ##
=========================================
  Coverage     79.51%   79.51%           
  Complexity     2216     2216           
=========================================
  Files           201      201           
  Lines         22612    22612           
=========================================
  Hits          17980    17980           
  Misses         4632     4632           
Flag Coverage Δ
tracer-extension 78.80% <ø> (ø)
tracer-php 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93994c0...4699915. Read the comment docs.

@iamluc iamluc marked this pull request as ready for review June 26, 2024 11:44
@iamluc iamluc requested a review from a team as a code owner June 26, 2024 11:44
@iamluc iamluc force-pushed the luc/ssi-oci-package branch 2 times, most recently from aa52f0f to 478a3e0 Compare July 1, 2024 13:15
@iamluc iamluc force-pushed the luc/ssi-oci-package branch from 478a3e0 to 4d1dc85 Compare July 8, 2024 09:57
@iamluc iamluc requested a review from a team as a code owner July 8, 2024 09:57
@iamluc iamluc changed the base branch from master to luc-ssi-package July 8, 2024 09:57
@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2024

Benchmarks

Benchmark execution time: 2024-07-08 10:25:29

Comparing candidate commit 4d1dc85 in PR branch luc/ssi-oci-package with baseline commit 291ea42 in branch luc-ssi-package.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics.

Base automatically changed from luc-ssi-package to master July 8, 2024 11:59
@iamluc iamluc force-pushed the luc/ssi-oci-package branch 3 times, most recently from f8460e3 to 4a31ca1 Compare July 8, 2024 12:02
@iamluc iamluc force-pushed the luc/ssi-oci-package branch from 3e98688 to 4699915 Compare July 10, 2024 07:42
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me ack this, I don't see obvious issues and we can unblock this then now :-)

@iamluc iamluc merged commit 3053d70 into master Jul 16, 2024
613 of 623 checks passed
@iamluc iamluc deleted the luc/ssi-oci-package branch July 16, 2024 12:39
@github-actions github-actions bot added this to the 1.2.0 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants