Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle OTel HTTP semantic conventions < 1.21.0 #2717

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Jun 17, 2024

Description

AIDM-162

The following system test was failing. This is because from OTel pov, doing setAttribute sets the status code in the metrics array.

This PR simply maps (and therefore overrides, if set) the deprecated http.status_code metric to the meta array.

This tag is set in Otel HTTP semantic versions inferior or equal than 1.21.0

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (5869a12) to head (eff1c80).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2717       +/-   ##
=============================================
- Coverage     77.83%   67.50%   -10.33%     
  Complexity     2212     2212               
=============================================
  Files           227      227               
  Lines         26599    26604        +5     
  Branches        988      988               
=============================================
- Hits          20703    17959     -2744     
- Misses         5370     8119     +2749     
  Partials        526      526               
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.60% <100.00%> (+<0.01%) ⬆️
tracer-php 50.62% <ø> (-29.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/serializer.c 81.48% <100.00%> (+0.08%) ⬆️

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5869a12...eff1c80. Read the comment docs.

@PROFeNoM PROFeNoM marked this pull request as ready for review June 17, 2024 13:18
@PROFeNoM PROFeNoM requested a review from a team as a code owner June 17, 2024 13:18
@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2024

Benchmarks

Benchmark execution time: 2024-06-17 13:19:21

Comparing candidate commit eff1c80 in PR branch alex/aidm/162 with baseline commit 5869a12 in branch master.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-12.831µs; -5.649µs] or [-5.186%; -2.283%]

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-18.827µs; -17.666µs] or [-9.733%; -9.133%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-17.982µs; -9.151µs] or [-6.121%; -3.115%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-16.848µs; -7.281µs] or [-5.298%; -2.290%]

@PROFeNoM PROFeNoM merged commit 3648fb5 into master Jun 17, 2024
600 of 606 checks passed
@PROFeNoM PROFeNoM deleted the alex/aidm/162 branch June 17, 2024 14:13
@github-actions github-actions bot added this to the 1.2.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants