Disable sidecar on 8.3 #2700
Merged
Disable sidecar on 8.3 #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2700 +/- ##
============================================
- Coverage 77.96% 77.85% -0.12%
Complexity 2212 2212
============================================
Files 227 227
Lines 26560 26560
Branches 988 988
============================================
- Hits 20707 20677 -30
- Misses 5327 5357 +30
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-06-10 11:31:40 Comparing candidate commit 57afd75 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead-opcache
|
bwoebi
approved these changes
Jun 10, 2024
morrisonlevi
pushed a commit
that referenced
this pull request
Jun 10, 2024
* disable sidecar on 8.3 * Update sidecar_fallback.phpt * Run tests without explicit sidecar --------- Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
pierotibou
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit d943c71.
Merged
pierotibou
added a commit
that referenced
this pull request
Jun 26, 2024
* Revert "Disable sidecar on 8.3 (#2700)" This reverts commit d943c71. * Use sidecar with v0.4 encoding support. * Prevent running the sidecar in the background sender test. * Increase request attempt number in order to avoid flakyness when sidecar is enabled. --------- Co-authored-by: Julio Gonzalez <julio.gonzalez@datadoghq.com>
bwoebi
added a commit
that referenced
this pull request
Oct 3, 2024
* Revert "Disable sidecar on 8.3 (#2700)" This reverts commit d943c71. * Enable sidecar sender in all integration tests. * Modify command. * Force flush on ZendFramework tests. * Fix instrumentation telemetry test Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix pcntl web test * Move ddtrace_tls_bases cleanup to gshutdown Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Pierre Bonet <pierotibou@gmail.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables Sidecar on PHP 8.3 while leaving all recent improvements when using the sidecar.
Reviewer checklist