Fix exception profiling in Generator->throw()

[bwoebi]

The prev_execute_frame of fake frame of the generator is not fixed up when throwing. Only when executing afterwards.

SCP-456

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-05-31 09:49:24

Comparing candidate commit b981d5c in PR branch bob/fix-exception-generator with baseline commit b1438ba in branch master.

Found 3 performance improvements and 3 performance regressions! Performance is the same for 172 metrics, 0 unstable metrics.

scenario:HookBench/benchWithoutHook-opcache

• 🟩 mem_peak [-212.596KB; -64.524KB] or [-10.006%; -3.037%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟩 execution_time [-7.991µs; -5.069µs] or [-5.270%; -3.343%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

• 🟩 execution_time [-5.664µs; -3.596µs] or [-3.790%; -2.406%]

scenario:PDOBench/benchPDOBaseline

• 🟥 execution_time [+13.946µs; +14.762µs] or [+7.962%; +8.428%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟥 execution_time [+17.510µs; +18.582µs] or [+10.093%; +10.711%]

scenario:PDOBench/benchPDOOverhead

• 🟥 execution_time [+12.533µs; +16.573µs] or [+4.617%; +6.106%]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.08%. Comparing base (b1438ba) to head (b981d5c).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2682      +/-   ##
============================================
- Coverage     79.36%   76.08%   -3.28%     
  Complexity     2223     2223              
============================================
  Files           200      226      +26     
  Lines         22322    26347    +4025     
  Branches          0      988     +988     
============================================
+ Hits          17715    20046    +2331     
- Misses         4607     5775    +1168     
- Partials          0      526     +526     

Flag	Coverage Δ
appsec-extension	69.13% <ø> (?)
tracer-extension	78.65% <54.54%> (-0.03%)	⬇️
tracer-php	75.46% <ø> (-4.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ext/handlers_api.c	64.28% <54.54%> (-35.72%)	⬇️

... and 39 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1438ba...b981d5c. Read the comment docs.

[morrisonlevi]

As discussed in Slack, Bob was able to find a reproducer for this crash in pure PHP (our extension isn't needed) and opened an upstream issue: Crash when stack walking in destructor of yielded from values during Generator->throw()

[realFlowControl]

Awesome work 🎉