Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile tracer version into sidecar #2678

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented May 28, 2024

Ensures that telemetry from the sidecar points to a proper version.

@bwoebi bwoebi requested review from a team as code owners May 28, 2024 16:25
Ensures that telemetry from the sidecar points to a proper version.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/sidecar-version branch from b9612c1 to 93216cc Compare May 28, 2024 20:09
@DataDog DataDog deleted a comment from datadog-datadog-prod-us1 bot May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.36%. Comparing base (6307408) to head (93216cc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2678      +/-   ##
============================================
+ Coverage     77.80%   79.36%   +1.56%     
  Complexity     2223     2223              
============================================
  Files           226      200      -26     
  Lines         26339    22322    -4017     
  Branches        988        0     -988     
============================================
- Hits          20492    17715    -2777     
+ Misses         5321     4607     -714     
+ Partials        526        0     -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.67% <ø> (ø)
tracer-php 80.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6307408...93216cc. Read the comment docs.

@morrisonlevi morrisonlevi merged commit b1438ba into master May 28, 2024
535 of 555 checks passed
@morrisonlevi morrisonlevi deleted the bob/sidecar-version branch May 28, 2024 21:09
@github-actions github-actions bot added this to the 1.1.0 milestone May 28, 2024
@bwoebi bwoebi modified the milestones: 1.1.0, 1.0.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants