Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build php extension for 5.4 locally #267

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Build php extension for 5.4 locally #267

merged 1 commit into from
Jan 29, 2019

Conversation

labbati
Copy link
Member

@labbati labbati commented Jan 28, 2019

Description

This PR enable building extension for php 5.4 locally.

Readiness checklist

  • [ ] Changelog entry added, if necessary
  • [ ] Tests added for this feature/bug

@labbati labbati requested a review from SammyK January 28, 2019 17:02
@labbati labbati added the 🍏 core Changes to the core tracing functionality label Jan 28, 2019
@labbati labbati added this to the 0.11.0 milestone Jan 28, 2019
@labbati labbati changed the title Build php 5.4 extension locally Build php extension for 5.4 locally Jan 28, 2019
SammyK
SammyK approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! :D

@labbati labbati merged commit 78e96e6 into master Jan 29, 2019
@labbati labbati deleted the labbati/build-54-local branch January 29, 2019 09:09
@labbati labbati self-assigned this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees

@labbati labbati

Labels
🍏 core Changes to the core tracing functionality
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@labbati @SammyK