-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update profiling deps/libdatadog v9 #2662
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2662 +/- ##
============================================
+ Coverage 77.72% 79.28% +1.56%
Complexity 2212 2212
============================================
Files 225 199 -26
Lines 26109 22092 -4017
Branches 988 0 -988
============================================
- Hits 20292 17515 -2777
+ Misses 5291 4577 -714
+ Partials 526 0 -526
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BenchmarksBenchmark execution time: 2024-05-17 14:59:00 Comparing candidate commit ff2c378 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 9 unstable metrics. scenario:walk_stack/1
|
8ebad32
to
9c9af30
Compare
9c9af30
to
72c41e0
Compare
This undoes a temporary change to see if the nightly version would work.
@@ -1114,7 +1122,7 @@ mod tests { | |||
} | |||
|
|||
#[test] | |||
#[cfg(feature = "timeline")] | |||
#[cfg(all(feature = "timeline", not(miri)))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated, but I was using cargo +nightly miri
locally to see if the specific nightly version was compatible with the changes, and this fails on miri:
error: unsupported operation:
extern
staticbindings::ffi::datadog_php_profiling_get_profiling_context
from cratedatadog_php_profiling
is not supported by Miri
profiling/Cargo.toml
Outdated
# with ahash 0.8.7 we run into https://github.com/tkaitchuck/aHash/issues/195 | ||
# should be fixed with updating Rust to 1.72 | ||
ahash = { version = "=0.8.6" } | ||
ahash = { version = "=0.8.11" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the comment above, thats not true anymore
Description
This bumps dependency versions to more recent releases, including libdatadog to v9.0.0.
Reviewer checklist