-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument AMQP batched publishing #2659
Instrument AMQP batched publishing #2659
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
============================================
- Coverage 79.18% 8.19% -70.99%
- Complexity 2208 2210 +2
============================================
Files 199 104 -95
Lines 22019 9189 -12830
============================================
- Hits 17435 753 -16682
- Misses 4584 8436 +3852
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 173 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks, happy to help. Do let me know if there's any change required 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 😃 It looks very good to me. There would only be some minor, semantical changes to be made ,and then it's all good to me 👍
PS: Sorry for the delay reviewing, I was OOO last week ;-)
This fixes DataDog#2644 by configuring the extension to trace the necessary methods.
63fe756
to
01d3595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😃 Thanks a lot for your superb contribution 🤗
Description
This fixes #2644 by configuring the extension to trace the necessary methods.
Reviewer checklist