Minor improvements #2651
Merged
Minor improvements #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamluc
force-pushed
the
luc/minor-improvements
branch
from
fbbce21 to
e6818f9
Compare
Note: components-rs/*.h files generated by cbindgen cannot be generated individually as they need to be deduplicated, so let's remove the individual Makefile targets and regenerate the files only with the "cbindgen" target.
iamluc
force-pushed
the
luc/minor-improvements
branch
from
e6818f9 to
fb94d7b
Compare
iamluc
commented
May 2, 2024
|
|
||
| generate_cbindgen: components-rs/ddtrace.h components-rs/telemetry.h components-rs/sidecar.h components-rs/common.h | ||
| generate_cbindgen: cbindgen_binary # Regenerate components-rs/ddtrace.h components-rs/telemetry.h components-rs/sidecar.h components-rs/common.h |
There was a problem hiding this comment.
Some context:
Currently in our dev Docker container, running make cbindgen deletes the components-rs/*.h files.
Then, because the cbindgen command is not installed, the generation of the files is skipped silently.
Finally it fails in the deduplication step because the files are missing.
As the components-rs/*.h files cannot be generated individually because their declarations need to be deduplicated, I believe it's simpler to generate them in the same Makefile target.
There was a problem hiding this comment.
I agree. And it's tidier :-)
bwoebi
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
CONTRIBUTING.md+ fix thecbindgenMakefile target not working without installingcbindgenmanually.Reviewer checklist