Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asm collected headers #2641

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update asm collected headers #2641

merged 1 commit into from
Apr 29, 2024

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Apr 24, 2024

Description

Update the list of collected headers on ASM.

APPSEC-52618

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Merging #2641 (a4ae4fb) into master (6d15aec) will decrease coverage by 1.69%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2641      +/-   ##
============================================
- Coverage     77.76%   76.07%   -1.69%     
  Complexity     2198     2198              
============================================
  Files           225      225              
  Lines         25959    25966       +7     
  Branches        986      986              
============================================
- Hits          20186    19753     -433     
- Misses         5247     5687     +440     
  Partials        526      526              
Flag Coverage Δ
appsec-extension 69.05% <100.00%> (+0.05%) ⬆️
tracer-extension 78.49% <ø> (ø)
tracer-php 75.73% <ø> (-4.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
appsec/src/extension/tags.c 82.28% <100.00%> (+0.20%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15aec...a4ae4fb. Read the comment docs.

@estringana estringana marked this pull request as ready for review April 24, 2024 12:25
@estringana estringana requested a review from a team as a code owner April 24, 2024 12:25
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please update the title and description.

@estringana estringana changed the title Update headers Update asm collected headers Apr 26, 2024
@estringana estringana force-pushed the estringana/update-headers branch from a4ae4fb to edb811e Compare April 29, 2024 08:11
@estringana estringana merged commit 20e6cda into master Apr 29, 2024
597 of 605 checks passed
@estringana estringana deleted the estringana/update-headers branch April 29, 2024 14:10
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants