refactor(profiling): shrink env/service/version and simplify #2640
Conversation
They were previously `Cow<'static, str>` and are now `String`. In practice they were rarely a borrowed string, and doing this shrinks the size of the request locals and is simpler to work with.
BenchmarksBenchmark execution time: 2024-04-23 20:31:53 Comparing candidate commit 64ed2e7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 10 unstable metrics. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## levi/stack_walking #2640 +/- ##
========================================================
- Coverage 77.76% 77.35% -0.41%
Complexity 2198 2198
========================================================
Files 225 199 -26
Lines 25959 21959 -4000
Branches 986 0 -986
========================================================
- Hits 20186 16986 -3200
+ Misses 5247 4973 -274
+ Partials 526 0 -526
Flags with carried forward coverage won't be shown. Click here to find out more. see 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
This changes the fields
env,service, andversioninRequestLocalsfromOption<Cow<'static, str>>toOption<String>. In practice they were rarely a borrowed string. Doing this shrinks the size of the request locals and is simpler to work with.Reviewer checklist