Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(profiling): fix some easy clippy lints #2633

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

realFlowControl
Copy link
Member

Description

This PR fixes some easy clippy complaints that showed up when running cargo +stable clippy

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner April 18, 2024 17:25
@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Apr 18, 2024
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2024

Benchmarks

Benchmark execution time: 2024-04-18 17:32:41

Comparing candidate commit a99494a in PR branch florian/clippy with baseline commit 8180fdb in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 26 metrics, 10 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Merging #2633 (a99494a) into master (8180fdb) will increase coverage by 0.67%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2633      +/-   ##
============================================
+ Coverage     78.67%   79.35%   +0.67%     
  Complexity     2198     2198              
============================================
  Files           199      199              
  Lines         21955    21935      -20     
============================================
+ Hits          17273    17406     +133     
+ Misses         4682     4529     -153     
Flag Coverage Δ
tracer-extension 78.48% <ø> (-0.04%) ⬇️
tracer-php 80.57% <ø> (+1.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8180fdb...a99494a. Read the comment docs.

@morrisonlevi morrisonlevi changed the title fix(profiling) some easy clippy complaints style(profiling): fix some easy clippy lints Apr 19, 2024
@morrisonlevi morrisonlevi merged commit 3a01a05 into master Apr 19, 2024
585 of 588 checks passed
@morrisonlevi morrisonlevi deleted the florian/clippy branch April 19, 2024 18:32
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants