Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Installer tests version lock #2630

Merged
merged 3 commits into from
Apr 17, 2024
Merged

fix: Installer tests version lock #2630

merged 3 commits into from
Apr 17, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Apr 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Merging #2630 (b771ef3) into master (e11c3aa) will increase coverage by 1.59%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2630      +/-   ##
============================================
+ Coverage     77.77%   79.37%   +1.59%     
  Complexity     2198     2198              
============================================
  Files           225      199      -26     
  Lines         25955    21955    -4000     
  Branches        986        0     -986     
============================================
- Hits          20186    17426    -2760     
+ Misses         5243     4529     -714     
+ Partials        526        0     -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.52% <ø> (ø)
tracer-php 80.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11c3aa...b771ef3. Read the comment docs.

@PROFeNoM PROFeNoM marked this pull request as ready for review April 17, 2024 12:43
@PROFeNoM PROFeNoM requested a review from a team as a code owner April 17, 2024 12:43
@PROFeNoM PROFeNoM merged commit 8180fdb into master Apr 17, 2024
554 of 555 checks passed
@PROFeNoM PROFeNoM deleted the alex/fix/installer-tests branch April 17, 2024 14:57
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants