fix(elasticsearch): Hook not being removed

[PROFeNoM]

Description

As mentioned in this GH comment from #2427, an elasticsearch hook wasn't removed

[ddtrace] [error] Could not add hook to Elastic\Elasticsearch\Endpoints\Indices::__construct with more than datadog.trace.hook_limit = 100 installed hooks in /opt/datadog-php/dd-trace-sources/bridge/_generated_integrations.php on line 5437; This message is only displayed once. Specify DD_TRACE_ONCE_LOGS=0 to show all messages.

dd_untrace was called on the Trait while it should have been called on the hooked class. With this PR, the installed hook is removed on the correct class.

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[codecov-commenter]

Codecov Report

Merging #2616 (d8ba1ab) into master (0d08bf6) will decrease coverage by 12.14%.
The diff coverage is 100.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##             master    #2616       +/-   ##
=============================================
- Coverage     76.53%   64.39%   -12.14%     
  Complexity     2609     2609               
=============================================
  Files           217      217               
  Lines         23318    23319        +1     
=============================================
- Hits          17846    15016     -2830     
- Misses         5472     8303     +2831     

Flag	Coverage Δ
tracer-extension	78.70% <ø> (ø)
tracer-php	46.83% <100.00%> (-27.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ions/ElasticSearch/V8/ElasticSearchIntegration.php	99.14% <100.00%> (+<0.01%)	⬆️

... and 19 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d08bf6...d8ba1ab. Read the comment docs.

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-04-05 14:50:46

Comparing candidate commit d8ba1ab in PR branch alex/issue/gh2427-ter with baseline commit 0d08bf6 in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 179 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

• 🟥 execution_time [+1.276µs; +3.124µs] or [+2.271%; +5.559%]

scenario:PDOBench/benchPDOBaseline

• 🟥 execution_time [+5.469µs; +12.953µs] or [+3.067%; +7.263%]

scenario:PDOBench/benchPDOBaseline-opcache

• 🟩 execution_time [-14.216µs; -6.178µs] or [-7.704%; -3.348%]

[bwoebi]

Looks good, thanks for tracking this down :-)