Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling) add uptime information to profiles #2610

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Apr 3, 2024

Description

This PR will add the info.json with only the start_time in RFC3339 format

{
    "application": {
        "start_time": "2024-12-31T23:59:59Z"
    }
}

In the profile view this will look like this:
image

The web-ui will magically calculate the uptime and show at the top and besides the time stamp. Next step is that we can create a metric out of this once we have this released

The feature used here was introduced in libdatadog with DataDog/libdatadog#289

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested review from a team as code owners April 3, 2024 12:50
@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Apr 3, 2024
@realFlowControl realFlowControl self-assigned this Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Merging #2610 (099d984) into master (6d15aec) will decrease coverage by 0.41%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2610      +/-   ##
============================================
- Coverage     77.76%   77.35%   -0.41%     
  Complexity     2198     2198              
============================================
  Files           225      199      -26     
  Lines         25959    21959    -4000     
  Branches        986        0     -986     
============================================
- Hits          20186    16986    -3200     
+ Misses         5247     4973     -274     
+ Partials        526        0     -526     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.49% <ø> (ø)
tracer-php 75.73% <ø> (-4.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15aec...099d984. Read the comment docs.

@realFlowControl realFlowControl requested a review from a team as a code owner April 24, 2024 07:26
@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2024

Benchmarks

Benchmark execution time: 2024-04-24 07:34:50

Comparing candidate commit 099d984 in PR branch florian/start-time with baseline commit 6d15aec in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

@realFlowControl realFlowControl merged commit fb712b5 into master Apr 25, 2024
579 of 588 checks passed
@realFlowControl realFlowControl deleted the florian/start-time branch April 25, 2024 06:53
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants