-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: UPGRADE-1.0.md #2609
docs: UPGRADE-1.0.md #2609
Conversation
BenchmarksBenchmark execution time: 2024-04-03 12:48:35 Comparing candidate commit 421e2ce in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics. scenario:TraceSerializationBench/benchSerializeTrace
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2609 +/- ##
============================================
+ Coverage 77.41% 79.19% +1.78%
============================================
Files 224 37 -187
Lines 25676 4187 -21489
Branches 976 0 -976
============================================
- Hits 19876 3316 -16560
+ Misses 5280 871 -4409
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. see 187 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
UPGRADE-1.0.md
Outdated
|-------------------------------------------|------------------------------|-------------------------| | ||
| `DD_TRACE_WORDPRESS_ENHANCED_INTEGRATION` | `false` | **Removed** (`true`) | | ||
| `DD_TRACE_WORDPRESS_CALLBACKS` | `false` | `true` | | ||
| `DD_TRACE_WORDPRESS_ADDITIONAL_ACTIONS` | `""` | `""` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the change in this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None. I just kept it to emphasize the fact that it wasn't modified, unlike the two others, but I didn't think about the fact that it can indeed be confusing. Would you prefer it to be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I found it confusing to be honest :-)
We may add a small note that users may enable DD_TRACE_ENABLED=1 before migrating to see the deprecations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks complete to me, thanks!
Description
Add an Upgrade Document outlining the changes and migrations (if any) associated with the 1.0 Major Release.
AIT-10083
Reviewer checklist