Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: UPGRADE-1.0.md #2609

Merged
merged 6 commits into from
Apr 16, 2024
Merged

docs: UPGRADE-1.0.md #2609

merged 6 commits into from
Apr 16, 2024

Conversation

PROFeNoM
Copy link
Contributor

@PROFeNoM PROFeNoM commented Apr 3, 2024

Description

Add an Upgrade Document outlining the changes and migrations (if any) associated with the 1.0 Major Release.

AIT-10083

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM marked this pull request as ready for review April 3, 2024 12:22
@PROFeNoM PROFeNoM requested a review from a team as a code owner April 3, 2024 12:22
@pr-commenter
Copy link

pr-commenter bot commented Apr 3, 2024

Benchmarks

Benchmark execution time: 2024-04-03 12:48:35

Comparing candidate commit 421e2ce in PR branch alex/docs/upgrade-1.0 with baseline commit 1fab516 in branch ddtrace-1.0.0.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+5.888µs; +10.912µs] or [+3.135%; +5.811%]

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Merging #2609 (dc33243) into master (1fab516) will increase coverage by 1.78%.
Report is 26 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2609      +/-   ##
============================================
+ Coverage     77.41%   79.19%   +1.78%     
============================================
  Files           224       37     -187     
  Lines         25676     4187   -21489     
  Branches        976        0     -976     
============================================
- Hits          19876     3316   -16560     
+ Misses         5280      871    -4409     
+ Partials        520        0     -520     
Flag Coverage Δ
appsec-extension ?
tracer-extension 79.19% <ø> (+0.73%) ⬆️
tracer-php ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 187 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fab516...dc33243. Read the comment docs.

UPGRADE-1.0.md Outdated
|-------------------------------------------|------------------------------|-------------------------|
| `DD_TRACE_WORDPRESS_ENHANCED_INTEGRATION` | `false` | **Removed** (`true`) |
| `DD_TRACE_WORDPRESS_CALLBACKS` | `false` | `true` |
| `DD_TRACE_WORDPRESS_ADDITIONAL_ACTIONS` | `""` | `""` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the change in this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None. I just kept it to emphasize the fact that it wasn't modified, unlike the two others, but I didn't think about the fact that it can indeed be confusing. Would you prefer it to be removed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I found it confusing to be honest :-)

@bwoebi bwoebi changed the base branch from ddtrace-1.0.0 to master April 12, 2024 14:16
@bwoebi
Copy link
Collaborator

bwoebi commented Apr 12, 2024

We may add a small note that users may enable DD_TRACE_ENABLED=1 before migrating to see the deprecations?

UPGRADE-1.0.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complete to me, thanks!

@bwoebi bwoebi added this to the 1.0.0beta1 milestone Apr 15, 2024
@github-actions github-actions bot removed this from the 1.0.0beta1 milestone Apr 16, 2024
@PROFeNoM PROFeNoM merged commit d4a4d56 into master Apr 16, 2024
121 of 399 checks passed
@PROFeNoM PROFeNoM deleted the alex/docs/upgrade-1.0 branch April 16, 2024 10:37
@bwoebi bwoebi added this to the 1.0.0beta1 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants