Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version reporting improvements #2588

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

pablomartinezbernardo
Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo commented Mar 21, 2024

Description

Make changes in how supported versions are reported from CI

  • Include all composer installed packages instead of only direct dependencies (Composer scenario dependencies are not considered direct dependencies)
  • Append to files instead of overriding. The versions are written from within ddSetUpBeforeClass, so there were cases where they might have been overriden and information lost.
  • Run composer show in the actual tests dir that it is used from.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Merging #2588 (a891a9d) into master (368284a) will decrease coverage by 27.67%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2588       +/-   ##
=============================================
- Coverage     76.94%   49.28%   -27.67%     
  Complexity     2564     2564               
=============================================
  Files           215      215               
  Lines         23076    23061       -15     
=============================================
- Hits          17756    11365     -6391     
- Misses         5320    11696     +6376     
Flag Coverage Δ
tracer-extension 78.80% <ø> (+0.07%) ⬆️
tracer-php 12.70% <ø> (-62.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368284a...a891a9d. Read the comment docs.

@pablomartinezbernardo pablomartinezbernardo changed the title Append version files instead of overwriting Version reporting improvements Apr 2, 2024
@pablomartinezbernardo pablomartinezbernardo marked this pull request as ready for review April 2, 2024 09:17
@pablomartinezbernardo pablomartinezbernardo requested a review from a team as a code owner April 2, 2024 09:17
@pablomartinezbernardo pablomartinezbernardo merged commit fd0d867 into master Apr 2, 2024
389 of 412 checks passed
@pablomartinezbernardo pablomartinezbernardo deleted the pmartinez/dont-rewrite-version-files branch April 2, 2024 09:25
@github-actions github-actions bot added this to the 0.99.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants