Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update update_span_duration return type #2586

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

Fixes #2585

Changes update_span_duration return type from null to false|null

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Mar 21, 2024
@PROFeNoM PROFeNoM requested a review from a team as a code owner March 21, 2024 07:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Merging #2586 (4150886) into master (5d2c3cb) will decrease coverage by 1.15%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2586      +/-   ##
============================================
- Coverage     76.94%   75.79%   -1.15%     
  Complexity     2564     2564              
============================================
  Files           215      241      +26     
  Lines         23076    27048    +3972     
  Branches          0      976     +976     
============================================
+ Hits          17756    20502    +2746     
- Misses         5320     6026     +706     
- Partials          0      520     +520     
Flag Coverage Δ
appsec-extension 69.13% <ø> (?)
tracer-extension 78.73% <ø> (ø)
tracer-php 74.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/ddtrace_arginfo.h 100.00% <ø> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2c3cb...4150886. Read the comment docs.

@PROFeNoM PROFeNoM merged commit 913e65e into master Mar 21, 2024
604 of 607 checks passed
@PROFeNoM PROFeNoM deleted the alex/chore/update_span_duration branch March 21, 2024 09:22
@github-actions github-actions bot added this to the 0.99.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Standalone null Return Type for update_span_duration Causes Phan Parsing to Fail for PHP <8.2
3 participants