Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative ext/ paths and test the windows installer #2559

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 6, 2024

Description

Fixes src/ dir copy and avoids the .dll suffix at all costs for windows.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

bwoebi and others added 2 commits March 6, 2024 18:53
@bwoebi bwoebi requested a review from a team as a code owner March 6, 2024 17:58
@bwoebi bwoebi force-pushed the bob/relative-ext-path branch from 286d343 to 17bbafb Compare March 6, 2024 18:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Merging #2559 (17bbafb) into master (f5c4106) will decrease coverage by 27.78%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2559       +/-   ##
=============================================
- Coverage     75.91%   48.13%   -27.78%     
  Complexity     2574     2574               
=============================================
  Files           240      214       -26     
  Lines         27029    23057     -3972     
  Branches        976        0      -976     
=============================================
- Hits          20519    11099     -9420     
- Misses         5990    11958     +5968     
+ Partials        520        0      -520     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.70% <ø> (ø)
tracer-php 10.31% <ø> (-64.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c4106...17bbafb. Read the comment docs.

@bwoebi bwoebi merged commit 1048c3a into master Mar 7, 2024
604 of 606 checks passed
@bwoebi bwoebi deleted the bob/relative-ext-path branch March 7, 2024 09:45
@github-actions github-actions bot added this to the 0.99.0 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants