Support for guzzle 6 #254
Merged
Support for guzzle 6 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
added
🎉 new-integration
labbati
commented
Jan 23, 2019
SammyK
suggested changes
Jan 23, 2019
| */ | ||
| protected function setUrlTag(Span $span, $request) | ||
| { | ||
| if (!is_a($request, '\GuzzleHttp\Message\RequestInterface')) { |
There was a problem hiding this comment.
Not a big deal for this PR, but just a TODO for later. Let's plan on changing all the is_a() calls throughout the codebase with instanceof which is roughly 50% faster (but all benchmarks are lies!) Lol.
There was a problem hiding this comment.
The advantage of this is that it is a string and it is probably less risky?
| /** | ||
| * Utility functions to handle version numbers and matching. | ||
| */ | ||
| final class Versions |
| * @param array|null $responseStack | ||
| * @return Client | ||
| */ | ||
| protected function getMockedClient(array $responseStack = null) |
Co-Authored-By: labbati <luca.abbati@datadoghq.com>
SammyK
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add support for Guzzle 6
Readiness checklist