Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the flaky unix socket test on CI environments #2535

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

PROFeNoM
Copy link
Contributor

Description

This test is just too flaky. Retries don't seem effective, and the issue still persists. This issue may arise because of a connection issue with the request replayer.

It is okay for us to mark this test as XFAIL, considering that we know it will sometimes fail for external reasons, and we seemingly have no actionable steps to take when this test is failing.

image

This time, it succeeded eight times in a row... This time will be the right one.

Reviewer checklist

  • Test coverage seems okay.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 22, 2024
@PROFeNoM PROFeNoM requested a review from a team as a code owner February 22, 2024 15:24
@bwoebi
Copy link
Collaborator

bwoebi commented Feb 22, 2024

I have a maybe better idea: avoid running it in CI, but run it locally? At least I'm not seeing it fail locally. So that there's at least some indication when things go wrong.

@PROFeNoM
Copy link
Contributor Author

That's a good idea (although for me, it either consistently passes or consistently fail locally)

@PROFeNoM PROFeNoM added the ci label Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Merging #2535 (0bdb4e6) into master (b25dc1e) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2535      +/-   ##
============================================
- Coverage     78.75%   78.74%   -0.01%     
  Complexity      267      267              
============================================
  Files           112      112              
  Lines         13482    13482              
============================================
- Hits          10618    10617       -1     
- Misses         2864     2865       +1     
Flag Coverage Δ
tracer-extension 78.70% <ø> (-0.01%) ⬇️
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25dc1e...0bdb4e6. Read the comment docs.

@PROFeNoM PROFeNoM changed the title Mark the flaky unix socket test as XFAIL Skip the flaky unix socket test on CI environments Feb 23, 2024
@PROFeNoM PROFeNoM merged commit b4daa1f into master Feb 23, 2024
541 of 543 checks passed
@PROFeNoM PROFeNoM deleted the alex/flaky/agent-flaky-section branch February 23, 2024 10:02
@github-actions github-actions bot added this to the 0.99.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants