Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex support from sampling rules #2529

Closed
wants to merge 1 commit into from

Conversation

PROFeNoM
Copy link
Contributor

Description

AIT-9144

As part of extended sampling, we now support only glob pattern matching. 

We still allow regexes and added a config knob to allow glob matching DD_TRACE_SAMPLING_RULES_FORMAT

We should drop both support for regexes and this config knob.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Feb 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2024

Benchmarks

Benchmark execution time: 2024-02-21 14:06:55

Comparing candidate commit ead89b8 in PR branch alex/major/regex-sampling with baseline commit b25dc1e in branch master.

Found 9 performance improvements and 0 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics.

scenario:SamplingRuleMatchingBench/benchGlobMatching1

  • 🟩 execution_time [-194.616ns; -81.984ns] or [-7.780%; -3.277%]

scenario:SamplingRuleMatchingBench/benchGlobMatching1-opcache

  • 🟩 execution_time [-165.706ns; -81.294ns] or [-6.524%; -3.201%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2

  • 🟩 execution_time [-223.371ns; -118.629ns] or [-8.532%; -4.531%]

scenario:SamplingRuleMatchingBench/benchGlobMatching2-opcache

  • 🟩 execution_time [-217.386ns; -101.614ns] or [-8.125%; -3.798%]

scenario:SamplingRuleMatchingBench/benchGlobMatching3

  • 🟩 execution_time [-258.360ns; -117.240ns] or [-9.290%; -4.216%]

scenario:SamplingRuleMatchingBench/benchGlobMatching3-opcache

  • 🟩 execution_time [-196.241ns; -98.559ns] or [-7.076%; -3.554%]

scenario:SamplingRuleMatchingBench/benchGlobMatching4

  • 🟩 execution_time [-178.233ns; -71.767ns] or [-6.776%; -2.728%]

scenario:SamplingRuleMatchingBench/benchGlobMatching4-opcache

  • 🟩 execution_time [-203.352ns; -100.848ns] or [-7.575%; -3.757%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟩 execution_time [-372.664ns; -166.136ns] or [-6.008%; -2.678%]

@PROFeNoM PROFeNoM closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant