Support json/xml request bodies #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2499 +/- ##
============================================
+ Coverage 76.53% 76.54% +0.01%
Complexity 267 267
============================================
Files 136 136
Lines 17526 17573 +47
Branches 1020 1034 +14
============================================
+ Hits 13413 13451 +38
- Misses 3580 3585 +5
- Partials 533 537 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
cataphract
force-pushed
the
glopes/server-req-body
branch
from
9712894 to
4a4d2af
Compare
cataphract
force-pushed
the
glopes/server-resp-body
branch
4 times, most recently
from
3a8a9de to
b4283de
Compare
cataphract
force-pushed
the
glopes/server-req-body
branch
from
4a4d2af to
20c5f0a
Compare
Also fix the handling of content-type/length in requests for the purposes of sending these headers to the helper and for setting the respective tags. These are available in $_SERVER['CONTENT_...'], not $_SERVER['HTTP_CONTENT_...']
cataphract
force-pushed
the
glopes/server-req-body
branch
from
20c5f0a to
498fae5
Compare
Anilm3
approved these changes
Feb 14, 2024
| @@ -657,6 +665,19 @@ static void _dd_http_client_ip(zend_array *meta_ht) | |||
| } | |||
| } | |||
|
|
|||
| static void _try_add_tag(zend_array *meta_ht, zend_string *tag_name, zval *val) | |||
| { | |||
|
|
|||
| @@ -34,6 +34,8 @@ | |||
| #define DD_TAG_HTTP_URL "http.url" | |||
| #define DD_TAG_NETWORK_CLIENT_IP "network.client.ip" | |||
| #define DD_PREFIX_TAG_REQUEST_HEADER "http.request.headers." | |||
| #define DD_TAG_HTTP_REQH_CONTENT_TYPE "http.request.headers.content-type" | |||
| #define DD_TAG_HTTP_REQH_CONTENT_LENGTH "http.request.headers.content-length" | |||
There was a problem hiding this comment.
nit: the naming of the request / response macros and interned strings could be a bit more consistent.
|
Naming stuff will be improved later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the handling of content-type/length in requests for the purposes of sending these headers to the helper and for setting the respective tags. These are available in
$_SERVER['CONTENT_...'], not$_SERVER['HTTP_CONTENT_...']APPSEC-51412
Description
Reviewer checklist