Parses schema extraction remote config configuration #2428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
force-pushed
the
estringana/schema-extraction-remote-config
branch
2 times, most recently
from
05825bc to
cbb6eed
Compare
estringana
force-pushed
the
estringana/schema-extraction-remote-config
branch
from
336d777 to
e4f9b11
Compare
Anilm3
reviewed
Jan 10, 2024
cataphract
requested changes
Mar 26, 2024
appsec/src/helper/sampler.hpp
Outdated
Comment on lines
71
to
73
| if (sample_rate_ != | ||
| valid_sample_rate(service_config_->get_request_sample_rate())) { | ||
| set_sampler_rate(service_config_->get_request_sample_rate()); |
There was a problem hiding this comment.
It makes no sense for you to be doing all these checks on each call to get(), then calling valid_sample_rate possibly twice, etc. Plus there's the lock and concurrent_, ...
What I suggest is:
- Make the only mutable variable in
samplerberequest_(an atomic that you can increment with fetch_add and relaxed memory order btw). - Keep the sample rate, but never change it.
- Remove the mutex. Remove,
service_config_. Removeconcurrent_, maybe, I've no idea what it's doing. - Do all the normalization of the sample rate on the sampler constructor or before calling the constructor.
- Store the sampler in an atomic shared_ptr if this is c++20 or previous facilities if before.
- The condition in
request_ < std::numeric_limits<unsigned>::max()is also redudant, unsigned numbers already wrap around.
estringana
force-pushed
the
estringana/schema-extraction-remote-config
branch
from
3597b5d to
3651c11
Compare
estringana
force-pushed
the
estringana/schema-extraction-remote-config
branch
from
3651c11 to
20cac65
Compare
cataphract
reviewed
Apr 22, 2024
estringana
force-pushed
the
estringana/schema-extraction-remote-config
branch
from
5e7989a to
ccf2514
Compare
cataphract
approved these changes
Apr 23, 2024
Anilm3
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Sorry I should've mentioned this sooner but the RFC related to sampling was deprecated in favour of a new one. So the sampling isn't provided through remote configuration any longer.
I'm not sure if there's anything from this PR you'd like to keep but otherwise it can't be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer checklist