Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macrobenchmark runs #2408

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add macrobenchmark runs #2408

merged 4 commits into from
Dec 6, 2023

Conversation

ddyurchenko
Copy link
Contributor

@ddyurchenko ddyurchenko commented Dec 5, 2023

Description

Allow running PHP laravel-realworld macrobenchmark directly from repository on Gitlab.

This PR enables 2 ways to run macrobenchmark:

  1. Automatically on every new commit in master branch.
  2. Manually on any commit in any branch.

Limitations

Due to how releases are downloaded from CircleCI, allows running macrobenchmark only on any of the last 20 commits from the target branch.

How to run benchmark manually

In your corresponding Gitlab pipeline, do the next steps:

  1. Run download_circle_ci_release job, so correct datadog-setup.php is downloaded from CircleCI.
  2. Run any / all macrobenchmark variants jobs. You won't be able to trigger benchmark job till download_circle_ci_release is complete.

How to see the results

In your Gitlab job, you will see the link to Datadog UI dashboard to monitor progress continuously, and after benchmark run is finished, also a link to BP UI.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@ddyurchenko ddyurchenko requested a review from a team as a code owner December 5, 2023 14:55
@ddyurchenko ddyurchenko requested a review from PROFeNoM December 5, 2023 14:55
@ddyurchenko ddyurchenko added the ci label Dec 5, 2023
Copy link
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😃

@PROFeNoM PROFeNoM merged commit cdf8d61 into master Dec 6, 2023
3 checks passed
@PROFeNoM PROFeNoM deleted the ddyurchenko/setup-macrobenchmarks branch December 6, 2023 14:45
@PROFeNoM PROFeNoM added this to the 0.95.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants