Always serialize schemas when available #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
approved these changes
Dec 5, 2023
Anilm3
force-pushed
the
anilm3/always-serialize-schemas
branch
from
97aca8b to
2f7d88a
Compare
estringana
reviewed
Dec 5, 2023
|
|
||
| double se_sample_rate = get_global_DD_API_SECURITY_REQUEST_SAMPLE_RATE(); | ||
| if (se_sample_rate >= MIN_SE_SAMPLE_RATE) { | ||
| mpack_write_bool(w, true); |
There was a problem hiding this comment.
I'd suggest to add some comments explaining what this line is
estringana
reviewed
Dec 5, 2023
| } | ||
| } | ||
|
|
||
| if (schema.length() <= max_schema_size) { |
There was a problem hiding this comment.
I think it would be good to add a debug line here saying schema key has been discarded because of size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently schemas are only provided to the extension when there's an event. This PR changes the subscriber to always add serialized schemas to meta whenever they're available.
Reviewer checklist