Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) fix xdebug #2405

Merged
merged 3 commits into from
Dec 5, 2023
Merged

fix(ci) fix xdebug #2405

merged 3 commits into from
Dec 5, 2023

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Dec 4, 2023

Description

This will fix the failing xdebug tests with the new containers and also add

  • sapi/cli/tests/bug80092.phpt and
  • Zend/tests/gh12073.phpt

to the xfail list. bug80092.phpt is already blacklisted for PHP 8.3 and might be unlisted with 8.3.1. gh12073 sets the memory limit to 2MB which is not possible anymore when the `dd_wrap_autoloader.php' is included.

gh12073 fails with:

========DIFF========
001+ Warning: Failed to set memory limit to 2097152 bytes (Current memory usage is 8388608 bytes) in /usr/local/src/php/Zend/tests/gh12073.php on line 10
001- Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d

PROF-8768

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl marked this pull request as ready for review December 4, 2023 16:49
@realFlowControl realFlowControl requested a review from a team as a code owner December 4, 2023 16:49
@realFlowControl realFlowControl self-assigned this Dec 5, 2023
@realFlowControl realFlowControl added this to the 0.95.0 milestone Dec 5, 2023
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@realFlowControl realFlowControl merged commit 598b629 into master Dec 5, 2023
3 checks passed
@realFlowControl realFlowControl deleted the florian/fix-xdebug-tests branch December 5, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants