Support for auto-instrumentation #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from-consts-to-class
…o labbati/autoinstrumentation
…o labbati/fix-54-tests
labbati
force-pushed
the
labbati/autoinstrumentation
branch
from
c48b9a8 to
942c2d2
Compare
…toinstrumentation
labbati
force-pushed
the
labbati/autoinstrumentation
branch
from
942c2d2 to
c3a739b
Compare
pawelchcki
previously approved these changes
Jan 21, 2019
| @@ -51,6 +51,8 @@ aliases: | |||
| image: php:7.2 | |||
| name: request_replayer | |||
| command: sh -c "curl --output index.php https://raw.githubusercontent.com/DataDog/dd-trace-php/dev/tests/request_replayer/index.php -q && php -S 0.0.0.0:80 index.php" | |||
| environment: | |||
| DD_REQUEST_DUMPER_FILE: dump.json | |||
There was a problem hiding this comment.
Almost Request dumpster fire :D <- this is the most useful Review comment of this decade
| $args = func_get_args(); | ||
| $options = $args[0]; | ||
|
|
||
| $classExist = class_exists('DDTrace_Ddtrace'); |
There was a problem hiding this comment.
:eye_twitch: at the random casing - I assume its as per Zend recommendation ?
There was a problem hiding this comment.
correct! it actually took as a while to understand! 😄
| @@ -203,6 +203,51 @@ static PHP_FUNCTION(dd_trace) { | |||
| RETURN_BOOL(rv); | |||
| } | |||
|
|
|||
| // This function allows untracing a function. | |||
| static PHP_FUNCTION(dd_untrace) { | |||
| @@ -16,8 +16,7 @@ | |||
| "app/database/seeds" | |||
| ], | |||
| "psr-4": { | |||
| "App\\": "app/", | |||
| "DDTrace\\": "../../../../src/DDTrace/" | |||
| @@ -0,0 +1,32 @@ | |||
| --TEST-- | |||
| Check a function can be untraced. | |||
There was a problem hiding this comment.
Small nitpick - this test could also verify other functions/methods still remain traced after one is untraced.
pawelchcki
approved these changes
Jan 21, 2019
|
Amazing work @labbati! :) |
bwoebi
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Update extraction ip algorithin * Add more tests for new ip headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for autoinstrumenting PHP code.
Readiness checklist