Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(profiling): extract interrupt manager #1948

Merged
merged 3 commits into from
Feb 28, 2023
Merged

refactor(profiling): extract interrupt manager #1948

merged 3 commits into from
Feb 28, 2023

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Feb 28, 2023 •
edited
Loading

Description

Creates a new struct InterruptManager that's created from extracting bits of code from the Profiler and TimeCollector.

Readiness checklist

  • Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.

@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label Feb 28, 2023
@morrisonlevi morrisonlevi added this to the 0.85.0 milestone Feb 28, 2023
@morrisonlevi morrisonlevi requested a review from a team as a code owner February 28, 2023 17:49
realFlowControl
realFlowControl approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. moar cleanup 🎉

Base automatically changed from levi/stalk-walking to master February 28, 2023 20:53
@morrisonlevi morrisonlevi force-pushed the levi/interrupt-manager branch from 1d22d5d to 8c13660 Compare February 28, 2023 20:53
@morrisonlevi morrisonlevi merged commit 1b880ef into master Feb 28, 2023
@morrisonlevi morrisonlevi deleted the levi/interrupt-manager branch February 28, 2023 20:54
@bwoebi bwoebi mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees
No one assigned
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.85.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morrisonlevi @realFlowControl