Mitigate panic in profiler shutdown, bound timeout #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigation is for issue #1919. It doesn't fix the root cause, which we haven't been able to determine yet. This also bounds our shutdown timeouts. Before, they _ought_ to have been bounded as a consequence of how the code was written, but this is explicit. It's also a tighter bound than before, 2 seconds instead of 10 seconds.
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This mitigation is for issue #1919. It doesn't fix the root cause, which we haven't been able to determine yet.
This also bounds our shutdown timeouts. Before, they ought to have been bounded as a consequence of how the code was written, but this is explicit. It's also a tighter bound than before, 2 seconds instead of 10 seconds.
Also, the new Rust 1.64 formatter apparently formats some things differently, so those are included as well.
Readiness checklist
Reviewer checklist