Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(profiling): increased allocation sampling distance to 512KiB #1913

Merged
merged 1 commit into from
Feb 8, 2023
Merged

perf(profiling): increased allocation sampling distance to 512KiB #1913

merged 1 commit into from
Feb 8, 2023

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Feb 8, 2023 •
edited by morrisonlevi
Loading

Description

Did some benchmarks in relenv and saw that we do not get a better resolution with 50 KB sampling distance compared to 512 KB, but we pay with a higher CPU time overhead.
This PR will lower the sampling distance to 512 KB.

PROF-7186

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@realFlowControl realFlowControl self-assigned this Feb 8, 2023
@realFlowControl realFlowControl added the profiling Relates to the Continuous Profiler label Feb 8, 2023
@realFlowControl realFlowControl changed the title prof(change) find better sampling distance prof(change) change allocation profiling sampling distance to 512 KB Feb 8, 2023
@realFlowControl realFlowControl added this to the 0.85.0 milestone Feb 8, 2023
@realFlowControl realFlowControl marked this pull request as ready for review February 8, 2023 14:39
@realFlowControl realFlowControl requested a review from a team as a code owner February 8, 2023 14:39
@morrisonlevi morrisonlevi changed the title prof(change) change allocation profiling sampling distance to 512 KB perf(profiling): increased allocation profiling sampling distance to 512 KB Feb 8, 2023
@morrisonlevi morrisonlevi changed the title perf(profiling): increased allocation profiling sampling distance to 512 KB perf(profiling): increased allocation sampling distance to 512 KB Feb 8, 2023
@morrisonlevi morrisonlevi changed the title perf(profiling): increased allocation sampling distance to 512 KB perf(profiling): increased allocation sampling distance to 512KiB Feb 8, 2023
morrisonlevi
morrisonlevi approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I recommended in slack when tracking the average number of stalk walks per requests. This may also still be too high, or the app I was tracking may generate a lot of garbage, but at least this is necessary. Thanks!

@morrisonlevi morrisonlevi merged commit f2b0e45 into master Feb 8, 2023
@morrisonlevi morrisonlevi deleted the florian/PROF-7186-find-better-sampling-distance branch February 8, 2023 15:47
@bwoebi bwoebi mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees

@realFlowControl realFlowControl

Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.85.0
Development

Successfully merging this pull request may close these issues.
2 participants
@realFlowControl @morrisonlevi